On 03/08/2015 15:19, Fabio Estevam wrote: > Hi Peter, > > On Mon, Aug 3, 2015 at 7:49 AM, vpeter4 <[email protected]> wrote: >> Currently we need to build one U-boot image for each of the udoo >> variants: quad and dual-lite. >> >> By switching to SPL we can support all two variants with a single binary. >> >> Based on the SPL for wandboard. >> >> Tested with OpenELEC (Open Embedded Linux Entertainment Center) >> on both boards. > > Looks very good. Great job! Just some minor issues: > >> Signed-off-by: vpeter4 <[email protected]> > > The preferred form is to pass the real name in the Signed-off tag, so > you should do: > > Signed-off-by: Peter Vicman <[email protected]> > >> Cc: Fabio Estevam <[email protected]> > > That's not a valid email address. You can use either > [email protected] or [email protected] > >> Cc: Stefano Babic <[email protected]> > > Maybe Stefano could fix these two small issues while applying your patch.
Yes, thanks for note this. I will fix them by applying, no need to repost. > > With these fixes in place: > > Acked-by: Fabio Estevam <[email protected]> > Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected] ===================================================================== _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
