On Thu, Aug 06, 2015 at 10:08:59AM -0500, Nishanth Menon wrote: > On 08/06/2015 10:04 AM, Tom Rini wrote: > > On Thu, Aug 06, 2015 at 09:48:27AM -0500, Nishanth Menon wrote: > > > >> This allows us to do basic math in hush shell. For example: > >> U-Boot# r1=10 > >> U-Boot# r2=20 > >> U-Boot# setexpr.l r3 $r1 + $r2 > >> U-Boot# echo $r3 > >> 30 > >> > >> Reported-by: Vitaly Andrianov <[email protected]> > >> Suggested-by: Tom Rini <[email protected]> > >> Signed-off-by: Nishanth Menon <[email protected]> > > > > This needs to be done in the configs/ files now instead as we have > > CMD_EXPR there. In fact I'm not sure right now which would win, the > > define here or the disable currently in the config files :) > > > yeah, I do many defconfigs define CONFIG_CMD_SETEXPR.. > > We dont have a common config file there(similar to ti_armv7_common) .. > we'd have to introduce this for every board config then... is'nt that > in-efficient?
Much like the kernel we try and pick sensible defaults. In this case you'd be removing a line from the defconfig files. But you're not the first to suggest that something better could be done here and maybe further down the line we'll play with the upstream tools for merging defconfig snippets so that we could have some common ones pulled together. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
