Hi Scott, On 31 August 2015 at 20:11, Scott Wood <[email protected]> wrote: > Currently, using fdt_fixup_stdout() on a device tree that is missing > the relevant alias results in this: > > WARNING: could not set linux,stdout-path FDT_ERR_NOTFOUND. > ERROR: /chosen node create failed > - must RESET the board to recover. > > FDT creation failed! hanging...### ERROR ### Please RESET the board ### > > There is no reason for this to be a fatal error rather than a warning, > and removing this allows for a smooth transition on a platform where > the device tree currently lacks the correct aliases but will have them > in the future.
Why do we need this patch - what platform? > > Signed-off-by: Scott Wood <[email protected]> > Cc: Kumar Gala <[email protected]> > Cc: Simon Glass <[email protected]> > --- > Resent with correct address for Simon Glass. > > common/fdt_support.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/common/fdt_support.c b/common/fdt_support.c > index f86365e..6052c77 100644 > --- a/common/fdt_support.c > +++ b/common/fdt_support.c > @@ -308,7 +308,8 @@ int fdt_chosen(void *fdt) > } > } > > - return fdt_fixup_stdout(fdt, nodeoffset); > + fdt_fixup_stdout(fdt, nodeoffset); Will some platforms will not boot correctly with this failing? Should we make your new feature a Kconfig options perhaps? I worry that it will become the default behaviour and then it will be hard to remove later. > + return 0; > } > > void do_fixup_by_path(void *fdt, const char *path, const char *prop, > -- > 2.1.4 > Regards, Simon _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
