Hi,

On 08-09-15 12:41, Philipp Rosenberger wrote:
The gd->malloc_ptr and the gd->malloc_limit are offsets to gd->malloc_base.
But the addr variable contains the absolute address. The new_ptr must be:
addr + bytes - gd->malloc_base.

Signed-off-by: Philipp Rosenberger <i...@linutronix.de>

You're right, good catch:

Reviewed-by: Hans de Goede <hdego...@redhat.com>

Regards,

Hans


---
  common/malloc_simple.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/malloc_simple.c b/common/malloc_simple.c
index 134e059..c745863 100644
--- a/common/malloc_simple.c
+++ b/common/malloc_simple.c
@@ -32,7 +32,7 @@ void *memalign_simple(size_t align, size_t bytes)
        void *ptr;

        addr = ALIGN(gd->malloc_base + gd->malloc_ptr, align);
-       new_ptr = addr + bytes;
+       new_ptr = addr + bytes - gd->malloc_base;
        if (new_ptr > gd->malloc_limit)
                return NULL;
        ptr = map_sysmem(addr, bytes);

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to