On 2015-09-28, Paul Kocialkowski wrote: > Le jeudi 24 septembre 2015 à 09:05 -0700, Vagrant Cascadian a écrit : >> I think the use of "time = mktime(time_universal);" is where the problem >> lies: > > […] > >> According to the mktime manpage: >> >> The mktime() function converts a broken-down time structure, >> expressed as local time, to calendar time representation. >> >> So my interpetation is that it's taking the UTC time and converts it >> into local time using the configured timezone... not sure what would be >> a viable alternative to mktime. > > That seems to make sense. Come to think of it, it probably was not > necessary to call gmtime in the first place: if SOURCE_DATE_EPOCH is > always in UTC, we should be able to stick that as-is in the time > variable. At best, gmtime + mktime (assuming mktime working in UTC) > would give us back the same timestamp. > > What do you think? Please let me know if I'm wrong.
This patch on top of 2015.10-rc4 seems to resolve the issue for me:
Index: u-boot/tools/default_image.c
===================================================================
--- u-boot.orig/tools/default_image.c
+++ u-boot/tools/default_image.c
@@ -108,8 +108,6 @@ static void image_set_header(void *ptr,
fprintf(stderr, "%s: SOURCE_DATE_EPOCH is not valid\n",
__func__);
time = 0;
- } else {
- time = mktime(time_universal);
}
} else {
time = sbuf->st_mtime;
It still checks for the validity of SOURCE_DATE_EPOCH using gmtime, but
doesn't call mktime at all, just re-uses the value set from
SOURCE_DATE_EPOCH.
live well,
vagrant
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
