Hi Simon,

On 09/29/2015 10:08 PM, Simon Glass wrote:
+       gd->arch.has_mmu = fdtdec_get_int(gd->fdt_blob, dev->of_offset,
+               "altr,has-mmu", 0);

Should that be fdtdec_get_bool()? Also is there a device tree binding
file for these settings?

With fdtdec_get_bool(), a boolean properly is true if present in the device tree and false if not present, regardless of its value.

It will be wrong if there is "altr,has-mmu = <0>;" .

A dts binding file will be added.

Thanks for your review.

Best regards,
Thomas
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to