Hi Christophe, On 6 October 2015 at 16:18, Christophe Ricard <[email protected]> wrote: > Hi Simon, > > This error is coming from the fact that no driver model is available for > powerpc and the config file mention in the error log > (controlcenterd_36BIT_SDCARD, controlcenterd_36BIT_SDCARD_DEVELOP, > controlcenterd_TRAILBLAZER, controlcenterd_TRAILBLAZER_DEVELOP). > > Do you think converting atmel driver to dm_tpm without dm_i2c dependency is > acceptable as a first step ? It would help to clean the TPM driver model. > > Do you think it make sense to convert powerpc i2c driver to i2c_dm ?
Yes that seems like the best idea. Regards, Simon > > Best Regards > Christophe > > 2015-10-04 18:25 GMT+02:00 Simon Glass <[email protected]>: >> >> Hi Christophe, >> >> On 3 October 2015 at 15:27, Simon Glass <[email protected]> wrote: >> > On 20 September 2015 at 21:00, Christophe Ricard >> > <[email protected]> wrote: >> >> tpm_atmel_twi can fit perfectly to the new UCLASS_TPM class. >> >> >> >> Signed-off-by: Christophe Ricard <[email protected]> >> >> Reviewed-by: Tom Rini <[email protected]> >> >> --- >> >> >> >> Changes in v3: None >> >> >> >> drivers/tpm/Kconfig | 2 +- >> >> drivers/tpm/tpm_atmel_twi.c | 74 >> >> ++++++++++++++++++++++++++++++++------------- >> >> 2 files changed, 54 insertions(+), 22 deletions(-) >> > >> > Acked-by: Simon Glass <[email protected]> >> >> I get errors with this patch: >> >> 03: dm: tpm: Add Driver Model support for tpm_atmel_twi driver >> powerpc: + controlcenterd_36BIT_SDCARD >> controlcenterd_36BIT_SDCARD_DEVELOP controlcenterd_TRAILBLAZER >> controlcenterd_TRAILBLAZER_DEVELOP >> +common/built-in.o: In function `do_tpm_raw_transfer': >> +build/../common/cmd_tpm.c:504: undefined reference to `tis_sendrecv' >> +lib/built-in.o: In function `tpm_sendrecv_command': >> +build/../lib/tpm.c:253: undefined reference to `tis_sendrecv' >> +lib/built-in.o: In function `tpm_init': >> +build/../lib/tpm.c:276: undefined reference to `tis_init' >> +build/../lib/tpm.c:280: undefined reference to `tis_open' >> >> Regards, >> Simon > > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
