On Wed, Oct 07, 2015 at 04:35:53PM +0200, Vincent Stehlé wrote: > On 10/07/2015 04:19 PM, Tom Rini wrote: > .. > > Were you in the Coverity talk too? :) > > Hi Tom, > > No, I was not following that talk, sorry.
Ah, coincidence then. > .. > > free(line); > > - return regex_report_error(&line->regex, err, > > "compile", > > + err = regex_report_error(&line->regex, err, > > "compile", > > tok); > > + return err; > > I am not sure you solve the problem this way. Indeed the structure > pointed to by the line pointer will still have been freed before use > even this way. Who knows what the memory contains when regerror() will > access &line->regex, which is contained into the freed structure? Er, bah. That's what I get for writing something in the middle of listening to a talk too. I meant to also move the free() to after the regex_report_error call and just avoid adding another variable. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
