On Mon 27 Jul 2009 08:13, Alessandro Rubini pondered: > Thanks for your comments. > > > Should have a CONFIG_ something - to make this conditional. > > This has been asked by Ben too. Will do, although I'm not very happy > about all those conditionals for every few lines of code.
There are 22,250 #ifdef in the code base already - a few more isn't going to make thing any uglier than it already is. :) > Some of your remarks are just symptoms of this being a quick hack, > like the memcpy not checked, the missed getenv and so on. Yeah, comments were for completeness, not a comment on the (nice & quick) function you put together... > > and I was doing md5 or sha1 on things to make sure that things came over > > properly... > > Yes, me too. Besides booting the stuff I got. > > /alessandro > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
