On Wed, Oct 21, 2015 at 01:24:42PM +0100, Peter Robinson wrote: > On Wed, Oct 21, 2015 at 12:55 PM, Tom Rini <[email protected]> wrote: > > On Wed, Oct 21, 2015 at 09:37:13AM +0100, Peter Robinson wrote: > >> >>> Felipe Balbi <[email protected]> writes: > >> >>> > Fix the following build break: > >> >>> > > >> >>> > drivers/usb/host/xhci-omap.c:35:5: error: ‘board_usb_init’ aliased > >> >>> > to external symbol ‘__board_usb_init’ > >> >>> > int board_usb_init(int index, enum usb_init_type init) > >> >>> > ^ > >> >>> > > >> >>> > Signed-off-by: Felipe Balbi <[email protected]> > >> >>> > >> >>> ping > >> >> > >> >> Where / how do I trigger this (or 2/2) ? > >> > > >> > GCC 5 > >> > >> I'm seeing exactly the same issue with gcc5 on Fedora, I've also seen > >> another issue with gcc5 with strcat for panda board variant names > >> which we hacked around [1]. > > > > So, I want to say that GCC 5.x (or at least 5.1) will be a known good > > compiler for v2016.01. I know that Fedora folks have been doing it for > > a while (yay, thanks) but I also know that Felipe has seen a few > > problems using some other (I think..) gcc-5 toolchain. So what I'm > > doing is getting the Fedora gcc-5 packages installed now, along with a > > Debian/unstable chroot where I can also get at all of their cross tools. > > > >> [1] > >> http://pkgs.fedoraproject.org/cgit/uboot-tools.git/tree/0009-ARM-fix-pandaboard-es-and-a4-revision-ID.patch?h=f23 > > > > That's interesting. I don't know why (and I would worry about) strcat > > failing, but since it's two string literals can't we just do a simple +? > > Or is my lack of coffee just yet causing me to forget that C is not > > every-other-language... > > It's more pointing it out that it worked for gcc < 5 and we saw this > regression with u-boot (numerous versions) built with gcc5, I'm not > sure why the panda board implementation did it like it did as opposed > to any other way, just worth looking out for those sorts of issues > elsewhere in the code.
OK, pulling up strcat(3) and I agree the current code is not correct. And a quick git grep shows that's the only abuse. I see the patch in question in my queue so I'll make sure to apply it. Thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
