On 23 October 2015 at 00:35, Marek Vasut <ma...@denx.de> wrote: > On Thursday, October 22, 2015 at 08:21:29 PM, Jagan Teki wrote: >> On 22 October 2015 at 23:45, Marek Vasut <ma...@denx.de> wrote: >> > On Thursday, October 22, 2015 at 07:45:49 PM, Jagan Teki wrote: >> >> BIT macro used on drivers/spi/* >> >> >> >> Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 .... 31 >> >> >> >> Cc: Tom Rini <tr...@konsulko.com> >> >> Cc: Simon Glass <s...@chromium.org> >> >> Cc: Masahiro Yamada <yamad...@jp.panasonic.com> >> >> Cc: Peng Fan <peng....@freescale.com> >> >> Cc: Stefan Roese <s...@denx.de> >> >> Cc: Marek Vasut <ma...@denx.de> >> >> Cc: Stephen Warren <swar...@nvidia.com> >> >> Cc: Tom Warren <twar...@nvidia.com> >> >> Signed-off-by: Jagan Teki <jt...@openedev.com> >> > >> > So, you're sending this horrid blob of changes instead of splitting them >> > into more managable parts, sigh. Moreover, I have a feeling this is a >> > change for the sake of changing something, not great. Also, you did not >> > describe how you performed this change -- was it done using some sort of >> > sed script or by hand ? >> >> Yes this is performed using sed > > The script you used should be explained somewhere.
OK, add in next version patches. > >> and as this a common change I have >> combined all spi drivers as I belongs to - did you see any wrong on >> this? > > It's hard to review such a big blob, furthermore if you need to adjust some > driver, you'd have to repost this whole thing instead of a single patch. OK, then I will resend it separate patches, for individual drivers. -- Jagan | openedev. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
