On Sat, Oct 24, 2015 at 11:37 AM, Fabio Estevam <[email protected]> wrote: > Hi Tom, > > On Sat, Oct 24, 2015 at 11:32 AM, Tom Rini <[email protected]> wrote: >> On Sat, Oct 24, 2015 at 10:28:04AM -0200, Fabio Estevam wrote: >> >>> From: Fabio Estevam <[email protected]> >>> >>> The ffs64() implementation for powerpc is not found in the Linux kernel, >>> so use the ffs64 header file from barebox. >>> >>> Imported from barebox v2015.10.0. >>> >>> Signed-off-by: Fabio Estevam <[email protected]> >> >> I'm confused. In the kernel __ffs64 is in <linux/bitops.h>, why do we >> need to do things differently here? > > It is true that kernel uses __ffs64 from <linux/bitops.h>, however in > U-boot (and barebox) there is also ffs64 for powerpc, so that's why I > added a new header for it. > > We have no ffs64 in kernel, only __ffs64.
After thinking more about it, I think we can simply use __ffs64 for powerpc as well. There is no assembly optimzation for ffs64 so we can use the generic __ffs64. Will prepare a new version doing this. Thanks _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
