Hi Wolfgang,
> Dear Axel Beierlein,
>
> In message <[email protected]> you wrote:
>> Signed-off-by: Axel Beierlein <[email protected]>
>> ---
>> Makefile | 7 +++++++
>> board/tqc/tqm5200/tqm5200.c | 9 ++++++++-
>> include/configs/TQM5200.h | 33 ++++++++++++++++++++++++++-------
>> 3 files changed, 41 insertions(+), 8 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 2a06440..7f197dd 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -764,6 +764,7 @@ Total5200_Rev2_lowboot_config: unconfig
>> }
>> @$(MKCONFIG) -a Total5200 ppc mpc5xxx total5200
>>
>> +HG43630_config \
>> cam5200_config \
>> cam5200_niosflash_config \
>> fo300_config \
>
> Please use a lower case board name, and keep list sorted.
>
>> @@ -808,6 +809,12 @@ TQM5200_STK100_config: unconfig
>> @[ -z "$(findstring HIGHBOOT,$@)" ] || \
>> { echo "TEXT_BASE = 0xFFF00000" >$(obj)board/tqm5200/config.tmp
>> ; \
>> }
>> + @[ -z "$(findstring HG43630,$@)" ] || \
>> + { echo "#define CONFIG_HG43630" >>$(obj)include/config.h ; \
>> + echo "#define CONFIG_TQM5200S"
>> >>$(obj)include/config.h ; \
>> + echo "#define CONFIG_TQM5200_B"
>> >>$(obj)include/config.h ; \
>> + $(XECHO) "... TQM5200S on Goetting HG43630 Board" ; \
>> + }
>> @$(MKCONFIG) -n $@ -a TQM5200 ppc mpc5xxx tqm5200 tqc
>
> Please don't add board specific configuration to the top level
> Makefile; do thi sin your board config file instead.
Can you explain what you want to see here? The board is based on a
tqm5200 module, so he actually does not want to copy his own config
file. Personally I think this solution to be ok, can you explain what
you don't like about it?
Cheers
Detlev
--
The success of PCs is in large part due to the fact that, by making all
hardware equivalent, good software enabled bad hardware. (Ugly)
-- Rob Pike
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: [email protected]
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
