Hi Jagan, On Mon, Nov 16, 2015 at 10:59 AM, Bin Meng <[email protected]> wrote: > Hi Jagan, > > On Mon, Oct 12, 2015 at 11:00 PM, Jagan Teki <[email protected]> wrote: >> Use the flash->flags for generic usage, not only for dm-spi-flash, >> this will be used for future flag additions. >> >> Signed-off-by: Jagan Teki <[email protected]> >> [Correct the spi flash flags detect logic] >> Signed-off-by: Bin Meng <[email protected]> >> Tested-by: Bin Meng <[email protected]> >> --- >> Changes for v4: >> - Fixed SNOR_F_SST_WR >> Changes for v3, v2: >> - none >> > > It turns out this patch breaks the Intel Crown Bay SPI flash. I > compared my original submitted patch with this patch you applied, and > surprisingly found there are differences ... > > My version is http://patchwork.ozlabs.org/patch/517704/ > You version below seems to modify some places which you thought would > be correct, but that's unfortunately wrong. If you reworked my patch, > I think you should remove at least my "Tested-by:" tag and ask me to > retest. > > Can you please help me understand what happened? I expected that you > should just grab my version and include it in your patch series. >
I see you were replying yesterday, but did not see any response on this one. [snip] Regards, Bin _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
