> -----Original Message----- > From: Wolfgang Denk [mailto:[email protected]] > Sent: Thursday, August 06, 2009 7:53 PM > To: Prafulla Wadaskar > Cc: [email protected]; Ashish Karkare; Prabhanjan Sarnaik > Subject: Re: [U-Boot] [PATCH] arm: Kirkwood: add SYSRSTn > Duration Counter Support > > Dear Prafulla Wadaskar, > > In message > <[email protected]> you wrote: > > This feature can be used to trigger special command > "sysrst_cmd" using > > reset key long press event (useful for reset to factory or > > manufacturing mode execution) > > Cool. > > > Implementation: upon long reset assertion (> 5secs) > sysrst_cmd will be > > executed if pre-defined in environment variables > > I like the feature, but I don't like the hardwired timeout value. > > > +#ifndef CONFIG_SYS_RST_THRESHOLD_TIME > > +#define CONFIG_SYS_RST_THRESHOLD_TIME 5 > > +#endif /* CONFIG_SYS_RST_THRESHOLD_TIME */ > > Could you please use an environment variable for this, i. e. > "sysrstcmd" and "sysrstdelay" (note that I omitted the > underscore, too, because it looks ugly to me). This goes more > in line with existing definitions like "bootcmd" and "bootdelay". This was in my mind too, the changes are ready, thanks for suggesting better names for environment variables. I will post v2 for the same
Regards... Prafulla . . > > Thanks. > > Best regards, > > Wolfgang Denk > > -- > DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: > [email protected] Your csh still thinks true is false. Write to your > vendor today and tell them that next year Configure ought > to "rm /bin/csh" unless they fix their blasted shell. :-) > - Larry Wall in Configure from the perl distribution > _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
