On Mon, Dec 07, 2015 at 06:47:36PM +0100, Wolfgang Denk wrote: > Dear Marek, > > In message <[email protected]> you wrote: > > > > Second is the coding which causes gcc 4.9.x and newer scream gruesome > > death and murder. The expression !x == 0 && !x == 1 is ambiguous and > > should instead be rewritten into (x != 0) && (x != 1) to be correct.
ok, part of the problem is that we aren't testing !x == 0 && !x == 1 (and I'm re-wording the commit msg, we had been talking about this on IRC) but "!x == 4 || !x == 6". > But (!x == 0) && (!x == 1) ist not the same as (x != 0) && (x != 1); > assume x=2: ... so this is a different thing to consider too. I'm re-wording things because in sum, what Philippe did is not straight forward, and Marek's version is. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
