On 15.12.2015 23:34, Joe Hershberger wrote:
> On Fri, Dec 11, 2015 at 6:03 AM, Michal Simek <michal.si...@xilinx.com> wrote:
>> Move driver to DM.
>>
>> Signed-off-by: Michal Simek <michal.si...@xilinx.com>
>
> A few nits below, but otherwise,
>
> Acked-by: Joe Hershberger <joe.hershber...@ni.com>
Thanks.
>> @@ -523,78 +520,105 @@ try_again:
>>
>> debug("Packet receive from 0x%p, length %dB\n", addr, length);
>> net_process_received_packet((uchar *)etherrxbuff, length);
>> - return length;
>> + return 0;
>
> Since there is no clean-up here, it would be better to return the
> length and remove the net_process_received_packet() call above.
I will send it in separate patch. I wanted to do it in this way to be
smaller patch.
>
>>
>
> Remove this line.
done.
>> +
>> +static const struct eth_ops emaclite_ops = {
>> + .start = emaclite_init,
>
> Name this emaclite_start.
>
>> + .send = emaclite_send,
>> + .recv = emaclite_recv,
>> + .stop = emaclite_halt,
>
> Name this emaclite_stop.
there will be separate patch for this.
Thanks,
Michal
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
