Hi Bin, On 10 January 2016 at 20:02, Bin Meng <bmeng...@gmail.com> wrote: > Hi Simon, > > On Fri, Jan 8, 2016 at 11:34 AM, Simon Glass <s...@chromium.org> wrote: >> Hi Bin, >> >> On 31 December 2015 at 01:53, Bin Meng <bmeng...@gmail.com> wrote: >>> When CONFIG_OF_STDOUT_VIA_ALIAS is on, always fix up kernel's stdout >>> string with hardcoded CONFIG_CONS_INDEX. >>> >>> This actually reverts commit 3e303f748cf57fb23e8ec95ab7eac0074be50e2b >>> "fdt_support: Add multi-serial support for stdout fixup", as the fix >> >> In that case, could this be a revert, created with 'git revert'? > > I've never used 'git revert' command. Did you mean this commit/patch > should be recreated using 'git revert'? Does this matter?
Well it creates a commit with a particular subject and format, which people are used to seeing for reverts. So if it is actually a revert, then yes I think you should use 'git revert'. You can edit the commit message to provide more detail. > >> >>> up in the /aliases node did not work under the following scenarios: >>> - Not every non-DM serial driver was written to have a driver name >>> that conforms the format of "serial%d" or "eserial%d". >>> - With driver model serial, the stdio_devices[] stores the serial >>> device node name in the device tree. >>> >>> Signed-off-by: Bin Meng <bmeng...@gmail.com> >>> --- >>> >>> common/fdt_support.c | 16 +--------------- >>> 1 file changed, 1 insertion(+), 15 deletions(-) >> > > Regards, > Bin Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
