Hi Bin,
On 19.01.2016 09:44, Bin Meng wrote:
On Tue, Jan 19, 2016 at 4:40 PM, Bin Meng <bmeng...@gmail.com> wrote:
Hi Stefan,
On Mon, Jan 18, 2016 at 5:56 PM, Stefan Roese <s...@denx.de> wrote:
Some BayTrail boards may want to use a different legacy UART than the
internal one. E.g. one provided by a Winbond Super IO chip, like the
W83627. This patch adds a function to disable this BayTrail internal
UART for this purpose.
Signed-off-by: Stefan Roese <s...@denx.de>
Cc: Bin Meng <bmeng...@gmail.com>
Cc: Simon Glass <s...@chromium.org>
---
arch/x86/cpu/baytrail/early_uart.c | 9 +++++++++
arch/x86/include/asm/u-boot-x86.h | 3 +++
2 files changed, 12 insertions(+)
diff --git a/arch/x86/cpu/baytrail/early_uart.c
b/arch/x86/cpu/baytrail/early_uart.c
index b64a3a9..716783c 100644
--- a/arch/x86/cpu/baytrail/early_uart.c
+++ b/arch/x86/cpu/baytrail/early_uart.c
@@ -76,3 +76,12 @@ int setup_early_uart(void)
return 0;
}
+
+int disable_internal_uart(void)
+{
+ /* Disable the legacy UART hardware. */
nits: please remove the ending peirod.
+ x86_pci_write_config32(PCI_DEV_CONFIG(0, LPC_DEV, LPC_FUNC), UART_CONT,
+ 0);
+
+ return 0;
+}
diff --git a/arch/x86/include/asm/u-boot-x86.h
b/arch/x86/include/asm/u-boot-x86.h
index dbf8e95..0c95796 100644
--- a/arch/x86/include/asm/u-boot-x86.h
+++ b/arch/x86/include/asm/u-boot-x86.h
@@ -47,6 +47,9 @@ int default_print_cpuinfo(void);
/* Set up a UART which can be used with printch(), printhex8(), etc. */
int setup_early_uart(void);
+/* Disable the internal legacy UART */
+int disable_internal_uart(void);
If we can call disable_internal_uart() in board-specific codes, then
this declaration can be moved to SoC-specific header instead of x86
generic one.
Let me check if your suggestion to patch 3/3 works and I'll re-spin
the patch series.
Thanks for the review,
Stefan
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
