Thanks for the review Prafulla! On Tue, 18 Aug 2009 03:12:07 -0700 Prafulla Wadaskar <[email protected]> wrote:
> > v2: Malloc send buffer (comment from Stefan Roese) > Malloc will always be an overhead. It's only allocated once (the first time a non-aligned buffer is passed), so the overhead is minimal. > I strongly recommend- we should pass aligned buffers from upper layers > to avoid such rework in all low level drivers, (few are already > aligned). We could put the same fix in eth_send instead. Then the issue is really just how we know what alignment requirement to go for. I guess one could add a field to the eth_device structure to store this and then fixup all drivers to supply this. If the rest of you thinks this is a good idea, I can cook up a patch. Opinions? > > v3: No need to use jumbo frames, use 1518 bytes buffer instead > Better to use PKTSIZE_ALIGN here, avoid magic numbers OK, I'll fix that. Thanks, // Simon _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
