> -----Original Message-----
> From: york sun
> Sent: Thursday, February 04, 2016 10:15 PM
> To: Harninder Rai; u-boot@lists.denx.de
> Subject: Re: [U-Boot] [PATCH] armv8/ls2080ardb: Enable VID support
>
> Rai,
>
> On 02/04/2016 06:25 AM, Rai Harninder wrote:
> > The fuse status register provides the values from on-chip voltage ID
> > efuses programmed at the factory. These values define the voltage
> > requirements for the chip. u-boot reads FUSESR and translates the
> > values into the appropriate commands to set the voltage output value
> > of an external voltage regulator.
>
> No need to repeat what VID feature is. Instead, please focus on what this
> patch
> does.
Ok. Will fix it in next revision of the patch
>
> >
> > #include <asm/io.h>
> > #ifdef CONFIG_LS1043A
> > #include <asm/arch/immap_lsch2.h>
> > +#elif defined(CONFIG_FSL_LAYERSCAPE)
> > +#include <asm/arch/immap_lsch3.h>
>
> It is not appropriate to use macro CONFIG_FSL_LAYERSCAPE here. It is defined
> for
> both LS1043 and LS2080.
Ok. I will instead use CONFIG_LS2080A
>
> > #else
> > #include <asm/immap_85xx.h>
> > #endif
> > @@ -285,7 +287,7 @@ static int set_voltage(int i2caddress, int vdd)
> > int adjust_vdd(ulong vdd_override) {
> > int re_enable = disable_interrupts(); -#ifdef CONFIG_LS1043A
> > +#if defined(CONFIG_LS1043A) || defined(CONFIG_FSL_LAYERSCAPE)
> > struct ccsr_gur *gur = (void *)(CONFIG_SYS_FSL_GUTS_ADDR); #else
>
> Same here.
>
>
> > +#ifdef CONFIG_FSL_LAYERSCAPE
> > + fusesr = in_le32(&gur->dcfg_fusesr); #else
> > fusesr = in_be32(&gur->dcfg_fusesr);
> > +#endif
>
> Are you sure you are not breaking LS1043 here?
My bad. As per your earlier comment, I shouldn't have used CONFIG_LAYERSCAPE.
>
> > +
> > #ifndef __ASSEMBLY__
> > unsigned long get_board_sys_clk(void); #endif
> >
>
> While you debug this feature on RDB board, please take a look at QDS as well.
Ok. Thanks for pointing out
>
> York
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
