Hi Jagan, On Wed, Feb 17, 2016 at 5:05 PM, Jagan Teki <jt...@openedev.com> wrote: > Hi Bin, > > On 17 February 2016 at 14:23, Bin Meng <bmeng...@gmail.com> wrote: >> Hi Jagan, >> >> On Mon, Feb 15, 2016 at 4:49 AM, Jagan Teki <jt...@openedev.com> wrote: >>> CONFIG_SPI_FLASH_ATMEL >>> CONFIG_SPI_FLASH_EON >>> CONFIG_SPI_FLASH_GIGADEVICE >>> CONFIG_SPI_FLASH_ISSI >>> >>> All these configs are grouped in CONFIG_SPI_NOR_MISC >> >> So these 4 configs are no longer needed? But I see they are still in >> the x86 config files, like the one we discussed here [1]. Should we >> remove them? > > I have updated them as well, in all x86 files too. > > diff --git a/configs/crownbay_defconfig b/configs/crownbay_defconfig > index dfc6b0f..2ebee29 100644 (file) > --- a/configs/crownbay_defconfig > +++ b/configs/crownbay_defconfig > @@ -20,7 +20,7 @@ CONFIG_OF_CONTROL=y > CONFIG_CPU=y > CONFIG_MTD_SPI_NOR=y > CONFIG_MTD_M25P80=y > -CONFIG_SPI_FLASH_GIGADEVICE=y > +CONFIG_SPI_NOR_MISC=y > CONFIG_SPI_NOR_MACRONIX=y > CONFIG_SPI_NOR_SST=y > CONFIG_SPI_NOR_WINBOND=y >
So how about the others? Looks a follow-up patch is needed to clean up the other configs? Each x86 board just have one type of SPI flash (and one driver instead) Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
