On Wed, Feb 17, 2016 at 09:09:27AM +0100, Guillaume GARDET wrote: > Since commit fd61d39970b9901217efc7536d9f3a61b4e1752a: > spl: mmc: add break statements in spl_mmc_load_image() > RAW and FS boot modes are now exclusive again. So, if MMCSD_MODE_RAW fails, > the > board hangs. This patch allows to try MMCSD_MODE_FS then, if available. > > It has been tested on a beaglebone black to boot on an EXT partition. > > Signed-off-by: Guillaume GARDET <[email protected]> > Cc: Tom Rini <[email protected]> > Cc: Nikita Kiryanov <[email protected]> > Cc: Igor Grinberg <[email protected]> > Cc: Paul Kocialkowski <[email protected]> > Cc: Pantelis Antoniou <[email protected]> > Cc: Simon Glass <[email protected]> > Cc: Matwey V. Kornilov <[email protected]> > > --- > common/spl/spl_mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c > index c3931c6..2eef0f2 100644 > --- a/common/spl/spl_mmc.c > +++ b/common/spl/spl_mmc.c > @@ -284,7 +284,7 @@ int spl_mmc_load_image(u32 boot_device) > if (!err) > return err; > #endif > - break; > + /* Fall through */ > case MMCSD_MODE_FS: > debug("spl: mmc boot mode: fs\n");
This also essentially reverts fd61d399. So Nikita, was there a specific use case that was broken before, or was the code just unclear in intentions here? Thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
