Dear Simon Kagstrom, In message <[email protected]> you wrote: > On Thu, 20 Aug 2009 01:11:09 +0200 > Jean-Christophe PLAGNIOL-VILLARD <[email protected]> wrote: > > > On 11:13 Tue 18 Aug , Simon Kagstrom wrote: > > > Define ffs/fls for all architectures > > > > > > UBIFS requires fls(), which is not defined for arm (and some other > > > architectures) and this patch adds it. The implementation is taken from > > > Linux and is generic. ffs() is also defined for those that miss it. > > > > > > v2: Unify code style (empty line between ffs/fls) > > please this > > > > > > Signed-off-by: Simon Kagstrom <[email protected]> > > > --- > > here > > I didn't add that myself - it's git format-patch that put it there.
What Jean-Christophe means is: Please don't put comments like "v2: Unify code style ..." in the area where the commit message is, but move them into the comment section, i. e. below the "---" line. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: [email protected] To be sure of hitting the target, shoot first and, whatever you hit, call it the target. _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
