On Thu, Mar 17, 2016 at 02:05:59PM +0000, Sáreník Ján wrote:
> Instead of `bootm ${loadaddr}#conf@1`
> one uses `bootm ${loadaddr}_conf@1`
>
> This fixes the bug with using just `bootm #conf@2`
> without $loadaddr where text starting with # is
> interpreted as a comment.
[snip]
> diff --git a/doc/uImage.FIT/command_syntax_extensions.txt
> b/doc/uImage.FIT/command_syntax_extensions.txt
> index 6c99b1c..ef4db80 100644
> --- a/doc/uImage.FIT/command_syntax_extensions.txt
> +++ b/doc/uImage.FIT/command_syntax_extensions.txt
> @@ -36,7 +36,7 @@ Old uImage:
> New uImage:
> 8. bootm <addr1>
> 9. bootm [<addr1>]:<subimg1>
> -10. bootm [<addr1>]#<conf>
> +10. bootm [<addr1>]_<conf>
> 11. bootm [<addr1>]:<subimg1> [<addr2>]:<subimg2>
> 12. bootm [<addr1>]:<subimg1> [<addr2>]:<subimg2> [<addr3>]:<subimg3>
> 13. bootm [<addr1>]:<subimg1> [<addr2>]:<subimg2> <addr3>
So the bug you've found is that we don't parse "bootm #conf@2"
correctly. We cannot change what has been working and is likely in the
wild of "bootm ${loadaddr}#conf@2". I think what we have to do here is
correct the syntax file here to note that addr1 is not optional in that
case and add a new form. I would first suggest seeing how it looks in
code to have "bootm conf@2" just work. If it ends up being too tricky
or complex, "bootm _conf@" is OK as the new one.
--
Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
