Hi Marek, On Fri, 2016-04-08 at 19:23 +0200, Marek Vasut wrote: > On 04/08/2016 07:08 PM, Alexey Brodkin wrote: > > > > Hi Marek, > > > > On Fri, 2016-04-08 at 19:05 +0200, Marek Vasut wrote: > > > > > > On 04/08/2016 07:00 PM, Alexey Brodkin wrote: > > > > > > > > > > > > Commit cf7c93cdd755 "usb: ehci: Implement V2P mapping" > > > > introduced usage of virt_to_phys() in ehci-hcd. > > > > > > > > Since there was no implementation of virt_to_phys() for ARC > > > > compilation of the ehci-generic driver failed. > > > > > > > > This change adds virt_to_phys() stub for ARC so now > > > > USB driver for AXS101 board could be built again. > > > > > > > > Signed-off-by: Alexey Brodkin <[email protected]> > > > > Cc: Marek Vasut <[email protected]> > > > > Cc: Daniel Schwierzeck <[email protected]> > > > > Cc: Hans de Goede <[email protected]> > > > > --- > > > > arch/arc/include/asm/io.h | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/arch/arc/include/asm/io.h b/arch/arc/include/asm/io.h > > > > index 281682c..b6f7724 100644 > > > > --- a/arch/arc/include/asm/io.h > > > > +++ b/arch/arc/include/asm/io.h > > > > @@ -239,4 +239,9 @@ static inline int __raw_writesl(unsigned int addr, > > > > void *data, int longlen) > > > > #define setbits_8(addr, set) setbits(8, addr, set) > > > > #define clrsetbits_8(addr, clear, set) clrsetbits(8, addr, clear, set) > > > > > > > > +static inline phys_addr_t virt_to_phys(void *vaddr) > > > > +{ > > > > + return (phys_addr_t)((unsigned long)vaddr); > > > > +} > > > > + > > > > #endif /* __ASM_ARC_IO_H */ > > > > > > > Sorry for breaking your arch. > > That happens. No problem. > > Real problem though is we still don't have autobuilder that > > catches these kinds of trivial flaws. > Synopsys can sponsor one , anytime ;-)
Ok I'll discuss this with my manager :) > > I don't build for all arches as well before submitting patches so > > before autobuilder is there we'll see more issues of that kind :) > buildman can help you here. Oh cool... I didn't know about it. Do you really use it? (kidding) For the record could you please ack this change so I may go forward and apply it to my tree? -Alexey _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
