Hi Simon, On Wed, Apr 20, 2016 at 08:40:10AM -0600, Simon Glass wrote: >Hi Peng, > >On 10 April 2016 at 23:34, Peng Fan <van.free...@gmail.com> wrote: >> Hi Simon, >> >> On Sat, Apr 09, 2016 at 12:34:13PM -0600, Simon Glass wrote: >>>Hi Peng, >>> >>>On 15 March 2016 at 19:32, Peng Fan <van.free...@gmail.com> wrote: >>>> In device tree, there is vmmc-supply property for SD/MMC. >>>> Introduce mmc_power_init function and pwrup hook function to let >>>> the specific drivers handle vmmc-supply. >>>> >>>> mmc_power_init will first invoke board_mmc_power_init to >>>> avoid break boards which already implement board_mmc_power_init. >>>> >>>> Then if pwrup hook functions have been implemented for different >>>> mmc drivers, pwrup will be invoked. >>>> >>>> Signed-off-by: Peng Fan <van.free...@gmail.com> >>>> Cc: Pantelis Antoniou <pa...@antoniou-consulting.com> >>>> Cc: Andrew Gabbasov <andrew_gabba...@mentor.com> >>>> Cc: Simon Glass <s...@chromium.org> >>>> Cc: Stephen Warren <swar...@nvidia.com> >>>> Cc: Clemens Gruber <clemens.gru...@pqgruber.com> >>>> Cc: Eric Nelson <e...@nelint.com> >>>> Cc: Stefano Babic <sba...@denx.de> >>>> Cc: Fabio Estevam <fabio.este...@nxp.com> >>>> --- >>>> drivers/mmc/mmc.c | 15 ++++++++++++++- >>>> include/mmc.h | 1 + >>>> 2 files changed, 15 insertions(+), 1 deletion(-) >>> >>>Acked-by: Simon Glass <s...@chromium.org> >>> >>>I wonder if there is a way to handle this property generically? >> >> Now I do not have a better idea for this (: >> >> Or we directly more the following piece code to driver/mmc/mmc.c? >> And Add a device entry for struct mmc. >> >> static int xxx_pwrup(struct mmc *mmc) >> { >> #ifdef CONFIG_DM_MMC >> struct udevice *vmmc_supply; >> int ret; >> >> ret = device_get_supply_regulator(mmc->dev, "vmmc-supply", >> &vmmc_supply); >> if (ret) { >> debug("No vmmc supply\n"); >> return 0; >> } >> >> ret = regulator_set_enable(vmmc_supply, true); >> if (ret) { >> puts("Error enabling VMMC supply\n"); >> return ret; >> } >> #endif >> return 0; >> } >> > >That seems better to me.
Ok, I'll try this new way. " we directly more the following piece code to driver/mmc/mmc.c? And Add a device entry for struct mmc. " Thanks, Peng. > >Regards, >Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot