Dear Kyungmin Park,

In message <9c9fda240909040411w468baddv9cdd59fafeab2...@mail.gmail.com> you 
wrote:
>
> > Do you use the very same U-Boot image on both SoCs?
> 
> Yes. One U-Boot image support 2 different CPU and 7 different boards.
> We don't want to make a u-boot for each board.

Ah, this explains a lot. Thanks for this explanation.

Um... do you have any plans how to handle this in a clean way that
will scale for additional SoCs and boards as well, and that
eventually can be used for other architectures, too?

I guess you will have to address the same issues in your Linux ports?

Do you consider using the device tree to implement the capability to
adjust the software configuration to the specifics of the current
hardware?  I think this would be really beneficial both for U-Boot and
Linux.


I have to admit that I'm pretty much stuck between a rock and a hard
place. I highly appreciate the fact that Samsung starts contributing
code to Linux and now also U-Boot mainline trees,. and as such I want
to encourage you all as much as possible, and not put any road blocks
in your way when it can be avoided.

I already hesitated when I rejected all these base address plus offset
things and demanded these to be changed to C structs. I am well aware
that is causes a lot of effort on your side without any immediately
visible benefit (your code is already running, so why change it?). 

On the other hand, I have to keep an eye at the overall code quality,
and to make sure the coderemains maintenable.

>From the patches I've seen so far I fear that we weill quickly see the
code copmplexity explode when it comes to handling different SoC and
board combinations within a single U-Boot image. I would like to point
out that we should not go the way that is currently being used in the
ARM Linux kernel. We will not duplicate the MACH_ID concepts used
there and the resulting code methods. Instead, when we need to add
such flexible configuration, we will go the device tree way. 

I hope such comment still comes in time to help you taking the right
turns.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
panic: kernel trap (ignored)
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to