Hi Stephen, On 12 April 2016 at 14:49, Stephen Warren <[email protected]> wrote: > On 04/09/2016 08:45 PM, Simon Glass wrote: >> >> Add driver-model block-device support to the IDE implementation. > > >> diff --git a/include/ide.h b/include/ide.h > > >> +struct udevice; >> +#ifdef CONFIG_BLK >> +ulong ide_read(struct udevice *dev, lbaint_t blknr, lbaint_t blkcnt, >> + void *buffer); >> +ulong ide_write(struct udevice *dev, lbaint_t blknr, lbaint_t blkcnt, >> + const void *buffer); >> +#else >> ulong ide_read(struct blk_desc *block_dev, lbaint_t blknr, lbaint_t >> blkcnt, >> void *buffer); >> ulong ide_write(struct blk_desc *block_dev, lbaint_t blknr, lbaint_t >> blkcnt, >> const void *buffer); >> +#endif > > > Does anything outside of the IDE code itself rely on these prototypes when > CONFIG_BLK is enabled? I'd hope to see #ifndef CONFIG_BLK added, without an > actual prototype since the function itself should be static once IDE is > converted to CONFIG_BLK?
Yes - see common/ide.c, which does use these functions. Cleaning that up might be a future task. There is certainly more potential here. Regards, Simon _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
