another observation -- noticed "#if 0" in a header file i'm working
with, so did a quick grep from the top:
$ grep -r "^#if 0" * | wc -l
223
$
and, what the heck:
$ grep -r "^#if 1" * | wc -l
37
$
so after next release, i might rummage around in that and submit
patches, particularly when i see stuff like:
#if 0 /* already in asm/8xx_immap.h */
#define TBSCR_REFA 0x0080 /* Reference Interrupt Status A
*/
#define TBSCR_REFB 0x0040 /* Reference Interrupt Status B
*/
#define TBSCR_REFAE 0x0008 /* Second Interrupt Enable A
*/
#define TBSCR_REFBE 0x0004 /* Second Interrupt Enable B
*/
#define TBSCR_TBF 0x0002 /* Time Base Freeze
*/
#define TBSCR_TBE 0x0001 /* Time Base Enable
*/
#endif
/*-----------------------------------------------------------------------
* PISCR - Periodic Interrupt Status and Control Register 11-31
*/
#undef PISCR_PIRQ /* TBD
*/
#define PISCR_PITF 0x0002 /* Periodic Interrupt Timer Freeze
*/
#if 0 /* already in asm/8xx_immap.h */
#define PISCR_PS 0x0080 /* Periodic interrupt Status
*/
#define PISCR_PIE 0x0004 /* Periodic Interrupt Enable
*/
#define PISCR_PTE 0x0001 /* Periodic Timer Enable
*/
#endif
after all, if you have a comment that helpfully states that that
content is #if 0'ed out because it's already elsewhere, then (after
confirming that it is), that seems like a good candidate for deletion.
all in good time ...
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot
