Hi Simon, On Sat, Jun 25, 2016 at 08:53:58PM -0600, Simon Glass wrote: > Hi Maxime, > > On 24 June 2016 at 08:27, Maxime Ripard > <[email protected]> wrote: > > The device tree overlays are a good way to deal with user-modifyable > > boards or boards with some kind of an expansion mechanism where we can > > easily plug new board in (like the BBB, the Raspberry Pi or the CHIP). > > > > Add a new function to merge overlays with a base device tree. > > > > Signed-off-by: Maxime Ripard <[email protected]> > > --- > > include/libfdt.h | 30 ++++ > > lib/Kconfig | 5 + > > lib/libfdt/Makefile | 2 + > > lib/libfdt/fdt_overlay.c | 381 > > +++++++++++++++++++++++++++++++++++++++++++++++ > > 4 files changed, 418 insertions(+) > > create mode 100644 lib/libfdt/fdt_overlay.c > > > > Is there a change log?
Yes, in the cover letter.
> > +static int overlay_update_local_node_references(void *fdto,
> > + int tree_node,
> > + int fixup_node,
> > + uint32_t delta)
> > +{
>
> Please add function comments for all of these.
Ack
> > +static int overlay_update_local_references(void *dto, uint32_t delta)
> > +{
> > + int fixups;
> > +
> > + fixups = fdt_path_offset(dto, "/__local_fixups__");
> > + if (fixups < 0) {
> > + /*
> > + * There's no local phandles to adjust, bail out
>
> On on line:
>
> /* There's not local ... */
Ok.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
