Hi, On 4 July 2016 at 11:10, Oleksandr Tymoshenko <[email protected]> wrote: > >> On Jul 4, 2016, at 8:40 AM, Simon Glass <[email protected]> wrote: >> >> On 1 July 2016 at 14:22, Oleksandr Tymoshenko <[email protected]> wrote: >>> Return value of rtl_send_common propogates unmodified all the way >>> up to eth_send and further to API consumer if CONFIG_API is enabled. >>> Previously rtl_send_common returned number of bytes sent on success >>> which was erroneouly detected as error condition by API consumers >>> that checked for operation success by comparing return value with 0. >>> >>> Switch rtl_send_common to use common convention: return 0 on success >>> and negative value for failure. >>> >>> Cc: Stephen Warren <[email protected]> >>> Cc: Joe Hershberger <[email protected]> >>> Signed-off-by: Oleksandr Tymoshenko <[email protected]> >>> --- >>> drivers/net/rtl8169.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Reviewed-by: Simon Glass <[email protected]> >> >> But I'd like to see a function comment on rtl_send_common(), and on >> the driver-model send() method in struct eth_ops, for that matter. > > Hi Simon, > > Should I submit new version or is it OK to submit new patch with comments > added to these two functions?
A new patch is fine, thanks. - Simon _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
