On 07/12, 2016 11:12 PM York wrote: > On 07/11/2016 09:08 PM, Yunhui Cui wrote: > > From: Yunhui Cui <[email protected]> > > > > Warnins log: > > drivers/spi/fsl_qspi.c: In function 'qspi_ahb_read': > > drivers/spi/fsl_qspi.c:400:16: warning: cast to pointer from integer of > different size [-Wint-to-pointer-cast] > > memcpy(rxbuf, (u8 *)(priv->cur_amba_base + priv->sf_addr), len); > > > > Signed-off-by: Yunhui Cui <[email protected]> > > --- > > drivers/spi/fsl_qspi.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index > > 75cbab2..6c69be4 100644 > > --- a/drivers/spi/fsl_qspi.c > > +++ b/drivers/spi/fsl_qspi.c > > @@ -386,6 +386,7 @@ static inline void qspi_ahb_read(struct > fsl_qspi_priv *priv, u8 *rxbuf, int len) > > { > > struct fsl_qspi_regs *regs = priv->regs; > > u32 mcr_reg; > > + void *rx_addr = NULL; > > > > mcr_reg = qspi_read32(priv->flags, ®s->mcr); > > > > @@ -393,8 +394,9 @@ static inline void qspi_ahb_read(struct > fsl_qspi_priv *priv, u8 *rxbuf, int len) > > QSPI_MCR_CLR_RXF_MASK | QSPI_MCR_CLR_TXF_MASK | > > QSPI_MCR_RESERVED_MASK | QSPI_MCR_END_CFD_LE); > > > > + rx_addr += priv->cur_amba_base + priv->sf_addr; > > /* Read out the data directly from the AHB buffer. */ > > - memcpy(rxbuf, (u8 *)(priv->cur_amba_base + priv->sf_addr), len); > > + memcpy(rxbuf, rx_addr, len); > > > > qspi_write32(priv->flags, ®s->mcr, mcr_reg); > > } > > > Would it be better to use (void *)(uintptr_t)(priv->cur_amba_base + > priv->sf_addr)? > > York > [Yunhui] Thanks for your suggestions , I will update it in v2.
Thanks Yunhui _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
