On 08/03/2016 11:46 AM, Alban Bedel wrote: > On Wed, 3 Aug 2016 09:00:42 +0200 > Marek Vasut <ma...@denx.de> wrote: > >> On 08/03/2016 07:32 AM, Alban Bedel wrote: >>> Commit 147271209a9d ("net: asix: fix operation without eeprom") >>> added a special handling for ASIX 88772B that enable another >>> type of header. This break the driver in DM mode as the extra handling >>> needed in the receive path is missing. >> >> So add the extra handling ? > > I can do that too, but I though u-boot preferred to avoid useless code.
Yes, if it is useless. >>> However this new header mode is not required and only seems to >>> increase the code complexity, so this patch revert this part of >>> commit 147271209a9d. >> >> Why is it not required ? > > It works fine without, since 2012. In fact this change is not even > mentioned in the log of commit 147271209a9d, so I really don't know why > it was added in the first place. As can be seen in the revert all it > does is adding 2 bytes to the USB packets that are then just skipped. > Seems pretty useless to me. I would like to get some feedback on this from Marcel, since he added this stuff. > Alban > -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot