On 08/29/2016 06:51 PM, [email protected] wrote:
The Colorado TK1 SOM is a small form factor board similar to the
Jetson TK1.  The main differences lie in the pinmux, and in that the
PCIe controller is set to use in 4lanes+1lane, rather than 2+2.

The pinmux header here was generated from a spreadsheet provided by
Colorado Engineering using the tegra-pinmux scripts.  The spreadsheet
was converted from v09 to v11 by me.

diff --git a/arch/arm/mach-tegra/tegra124/Kconfig 
b/arch/arm/mach-tegra/tegra124/Kconfig

+config TARGET_CEI_TK1_SOM
+       bool "Colorado/NVIDIA Tegra124 TK1-som board"

I think that should say:

        bool "Colorado Engineering Inc TK1-som board"

I assume that NVIDIA had no part in creating this derivative; they simply created the board it was based on.

diff --git a/include/configs/cei-tk1-som.h b/include/configs/cei-tk1-som.h

+ * (C) Copyright 2016 Peter Chubb
+ * Based on the jetson-tk1.h which is

There's trailing whitespace on that line.

I might suggest adding a : to the end of the line, so it's more obvious (when looking at just the added lines) that it's referring to the next line rather than a statement that wasn't finished.

diff --git a/board/cei/cei-tk1-som/pinmux-config-cei-tk1-som.h 
b/board/cei/cei-tk1-som/pinmux-config-cei-tk1-som.h

+/*
+ * THIS FILE IS AUTO-GENERATED - DO NOT EDIT!
+ *
+ * To generate this file, use the tegra-pinmux-scripts tool available from
+ * https://github.com/NVIDIA/tegra-pinmux-scripts
+ * Run "board-to-uboot.py cei-tk1-som".
+ */

Is that true? I'd like to see a patch for tegra-pinmux-scripts that adds the config file for this board too.

Aside from those minor issues,
Acked-by: Stephen Warren <[email protected]>
_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to