On Tue, Aug 30, 2016 at 12:33:05PM -0600, Simon Glass wrote: > Hi Masahiro, > > On 29 August 2016 at 21:25, Masahiro Yamada > <yamada.masah...@socionext.com> wrote: > > 2016-08-30 9:21 GMT+09:00 Simon Glass <s...@chromium.org>: > >> Move this option to Kconfig and tidy up existing uses. > >> > >> Signed-off-by: Simon Glass <s...@chromium.org> > > > >> > >> diff --git a/arch/arm/cpu/armv7/am33xx/Kconfig > >> b/arch/arm/cpu/armv7/am33xx/Kconfig > >> index efbc219..54474c2 100644 > >> --- a/arch/arm/cpu/armv7/am33xx/Kconfig > >> +++ b/arch/arm/cpu/armv7/am33xx/Kconfig > >> @@ -3,6 +3,9 @@ if AM43XX > >> config SPL_EXT_SUPPORT > >> default y > >> > >> +config SPL_GPIO_SUPPORT > >> + default y > >> + > >> config TARGET_AM43XX_EVM > >> bool "Support am43xx_evm" > >> select TI_I2C_BOARD_DETECT > >> diff --git a/arch/arm/cpu/armv7/omap3/Kconfig > >> b/arch/arm/cpu/armv7/omap3/Kconfig > >> index de65ac6..e1c981e 100644 > >> --- a/arch/arm/cpu/armv7/omap3/Kconfig > >> +++ b/arch/arm/cpu/armv7/omap3/Kconfig > >> @@ -6,6 +6,9 @@ config SPL_EXT_SUPPORT > >> config SPL_FAT_SUPPORT > >> default y > >> > >> +config SPL_GPIO_SUPPORT > >> + default y > >> + > >> choice > >> prompt "OMAP3 board select" > >> optional > >> diff --git a/arch/arm/cpu/armv7/omap4/Kconfig > >> b/arch/arm/cpu/armv7/omap4/Kconfig > >> index 92eb2f4..48ce9d3 100644 > >> --- a/arch/arm/cpu/armv7/omap4/Kconfig > >> +++ b/arch/arm/cpu/armv7/omap4/Kconfig > >> @@ -6,6 +6,9 @@ config SPL_EXT_SUPPORT > >> config SPL_FAT_SUPPORT > >> default y > >> > >> +config SPL_GPIO_SUPPORT > >> + default y > >> + > >> choice > >> prompt "OMAP4 board select" > >> optional > >> diff --git a/arch/arm/cpu/armv7/omap5/Kconfig > >> b/arch/arm/cpu/armv7/omap5/Kconfig > >> index e367828..5b049ad 100644 > >> --- a/arch/arm/cpu/armv7/omap5/Kconfig > >> +++ b/arch/arm/cpu/armv7/omap5/Kconfig > >> @@ -6,6 +6,9 @@ config SPL_EXT_SUPPORT > >> config SPL_FAT_SUPPORT > >> default y > >> > >> +config SPL_GPIO_SUPPORT > >> + default y > >> + > >> choice > >> prompt "OMAP5 board select" > >> optional > >> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > >> index c25fcf3..d4a5bc9 100644 > >> --- a/arch/arm/mach-exynos/Kconfig > >> +++ b/arch/arm/mach-exynos/Kconfig > >> @@ -61,6 +61,9 @@ endif > >> > >> if ARCH_EXYNOS5 > >> > >> +config SPL_GPIO_SUPPORT > >> + default y > >> + > > > > > > As we discussed before, > > we decided to not do this. > > Tom was keen to avoid changing every defconfig file. It is there > another way to express common defaults?
I was thinking in the Kconfig with the entry for SPL_GPIO_SUPPORT, for optional stuff and select in the board, etc, Kconfig for non-optional stuff. Now, I realize that optional vs non-optional is more the domain of the individual SoC custodians, so we'll have some clean up afterwards that isn't on you (well, aside from the SoCs you know like rockchip ;)). -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot