On 09/04/2016 01:38 AM, Masahiro Yamada wrote: > 2016-09-02 23:12 GMT+09:00 Marek Vasut <[email protected]>: >> On 09/02/2016 03:09 PM, Masahiro Yamada wrote: >>> 2016-09-02 20:58 GMT+09:00 Marek Vasut <[email protected]>: >>>> On 09/02/2016 12:36 PM, Masahiro Yamada wrote: >>>>> -ret = expression; >>>>> -if (ret) >>>>> - return ret; >>>>> -return 0; >>>>> +return expression; >>>>> >>>>> Signed-off-by: Masahiro Yamada <[email protected]> >>>>> --- >>>> >>>> The thing I miss in the commit message is -- why is this change >>>> beneficial/needed ? >>>> >>> >>> I thought the benefit was apparent. >>> >>> Wasn't it to you? >> >> Nope, please explain. >> > > This is a cleanup patch; it removes > unneeded variable assignments, if conditionals.
This should be in the commit message. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
