Hello Joakim, Joakim Tjernlund wrote: >> Dear Joakim Tjernlund, >> >> In message <1253178437-32398-1-git-send-email-joakim.tjernl...@transmode.se> >> you wrote: >>> After issuing a STOP one must wait until the STOP has completed >>> on the bus before doing something new to the controller. >>> >>> Also add an extra read of SR as the manual mentions doing that >>> is a good idea. >>> >>> Remove surplus write of CR just before a write, isn't required and >>> could potentially disturb the I2C bus. >>> >>> Signed-off-by: Joakim Tjernlund <joakim.tjernl...@transmode.se> >>> --- >>> drivers/i2c/fsl_i2c.c | 12 ++++++++---- >>> 1 files changed, 8 insertions(+), 4 deletions(-) >> Could you _please_ start adding some version information to your >> patches, and a list of changes between the versions? >> >> Thanks. > > Yes, that was a bit sloppy on my part, sorry. What do you want > me to do now? > Resend the whole series or do I get away with it this time? > All but the last patch is in u-boot-i2c testing(by Heiko) repo already.
You mean with last patch, this patch:? http://lists.denx.de/pipermail/u-boot/2009-September/061187.html If, so, I think, I add it also to the u-boot-i2c testing branch, and it is OK for now, but please for further patches, add some information as Wolfgang suggested. thanks bye Heiko _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot