On 09/20/2016 03:30 PM, Tom Rini wrote:
> On Tue, Sep 20, 2016 at 09:40:00PM +0000, york sun wrote:
>> On 09/20/2016 02:36 PM, Tom Rini wrote:
>>> On Tue, Sep 20, 2016 at 09:22:09PM +0000, york sun wrote:
>>>> Tom and Simon,
>>>> After commit 371244cb19f9804711dd66e4281ff7979915fd2e, all merges with
>>>> new macros defined will have the compiling error. How shall we fix it?
>>>> Some macros can be added to Kconfig. But some are for local use, better
>>>> than magic numbers. Adding them to the white-list doesn't sound right.
>>>> What's your suggestion?
>>> Things that don't belong in Kconfig don't belong in the CONFIG namespace
>>> either, probably. For example, the cache line stuff is in Kconfig and
>>> select'ed but for another example, various magic numbers used in the TI
>>> secure boot stuff (which can vary from SoC to SoC) are just not in the
>>> CONFIG namespace now.
>> For those can be put in Kconfig, I can convert.
>> Can you point me examples to use macros for magic numbers?
>> What about the white listed macros? Are we supposed to leave them there,
>> or slowly convert them to other name space?
> Things on the whitelist should be converted, either to Kconfig or moved
> out of the namespace. Can you give me an example of something you
> aren't sure how to convert?
Those are DDR parameters defined per board if used. What will be proper
names to convert to?
U-Boot mailing list