On Mon, Sep 19, 2016 at 04:33:12PM -0600, Simon Glass wrote:

> This converts the following to Kconfig:
>    CONFIG_SYS_STDIO_DEREGISTER
> 
> This option should never be enabled in SPL, so use
> CONFIG_IS_ENABLED(SYS_STDIO_DEREGISTER) when checking the option.
> 
> Signed-off-by: Simon Glass <s...@chromium.org>
[snip]
> diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
> index 76909ee..3800225 100644
> --- a/arch/arm/mach-tegra/Kconfig
> +++ b/arch/arm/mach-tegra/Kconfig
> @@ -12,6 +12,9 @@ config SPL_LIBGENERIC_SUPPORT
>  config SPL_SERIAL_SUPPORT
>       default y
>  
> +config SYS_STDIO_DEREGISTER
> +     default y
> +
>  config TEGRA_IVC
>       bool "Tegra IVC protocol"
>       help
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 5193ee7..b15935d 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -34,6 +34,9 @@ config VENDOR_INTEL
>  
>  endchoice
>  
> +config SYS_STDIO_DEREGISTER
> +     default y if X86
> +
>  # board-specific options below
>  source "board/advantech/Kconfig"
>  source "board/congatec/Kconfig"
> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig
> index 9954f0a..23413f1 100644
> --- a/board/sunxi/Kconfig
> +++ b/board/sunxi/Kconfig
> @@ -27,6 +27,9 @@ config SPL_POWER_SUPPORT
>  config SPL_SERIAL_SUPPORT
>       default y
>  
> +config SYS_STDIO_DEREGISTER
> +     default y
> +
>  config PRE_CONSOLE_BUFFER
>  # Note only one of these may be selected at a time! But hidden choices are
>  # not supported by Kconfig
> diff --git a/common/Kconfig b/common/Kconfig
> index 815e11d..149d002 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -326,6 +326,14 @@ config SYS_CONSOLE_INFO_QUIET
>         Enable this option to supress this output. It can be obtained by
>         calling stdio_print_current_devices() from board code.
>  
> +config SYS_STDIO_DEREGISTER
> +     bool "Allow deregistering stdio devices"
> +     help
> +       Generally there is no need to deregister stdio devices since they
> +       are never deactivated. But if a stdio device is used which can be
> +       removed (for example a USB keyboard) then this option can be
> +       enabled to ensure this is handled correctly.
> +

Maybe this needs to be default y if we have USB_KBD and a few other
things?  This isn't as bad as some of the others, so if we need to come
back later on this, that's OK I suppose..  Thanks!

-- 
Tom

Attachment: signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to