On 24.9.2016 19:26, Simon Glass wrote: > Hi Michal, > > On 8 September 2016 at 07:57, Michal Simek <michal.si...@xilinx.com> wrote: >> This patch also includes ARM64 zynqmp changes: >> - Remove platform non DM initialization >> - Remove hardcoded sata base address >> >> Signed-off-by: Michal Simek <michal.si...@xilinx.com> >> --- >> >> There are probably more things to test and to check but >> on my platform I can connect only one HDD. But IP itself >> have two ports which are not handled properly. >> I have tried to reuse as much infrastructure as is available. >> There need to be cleanup for SATA/SCSI/AHCI names. >> >> There is also sata cmd and it is a question if make sense to keep it in >> the tree because it is subset of scsi commands. >> >> scsi scan needs to be called first and maybe make sense to call it >> automatically as was done before. >> >> Simon: Please check if I did it at least partially right. >> >> TODO: >> CONFIG_DM_SATA should be moved to Kconfig >> >> LOG: >> >> ZynqMP> scsi scan >> SATA link 0 timeout. >> Target spinup took 0 ms. >> AHCI 0001.0301 32 slots 2 ports 6 Gbps 0x3 impl SATA mode >> flags: 64bit ncq pm clo only pmp fbss pio slum part ccc apst >> scanning bus for devices... >> Device 0: (1:0) Vendor: ATA Prod.: KINGSTON SVP200S Rev: 501A >> Type: Hard Disk >> Capacity: 57241.8 MB = 55.9 GB (117231408 x 512) >> Found 1 device(s). >> ZynqMP> ls sata 0 >> <DIR> 4096 . >> <DIR> 4096 .. >> <DIR> 4096 bin >> <DIR> 4096 boot >> <DIR> 4096 dev >> <DIR> 12288 etc >> <DIR> 4096 home >> <DIR> 4096 lib >> <DIR> 4096 lost+found >> <DIR> 4096 media >> <DIR> 4096 mnt >> <DIR> 4096 opt >> <DIR> 4096 proc >> <DIR> 4096 root >> <DIR> 4096 run >> >> --- >> arch/arm/include/asm/arch-zynqmp/hardware.h | 2 -- >> board/xilinx/zynqmp/zynqmp.c | 11 ------- >> drivers/block/sata_ceva.c | 49 >> +++++++++++++++++++++++++++-- >> include/configs/xilinx_zynqmp.h | 7 +++-- >> 4 files changed, 52 insertions(+), 17 deletions(-) > > Looks good to me - this is how a driver should be organised.
Great. Thanks, Michal _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot