Hi Minghuan,

On Tue, Oct 11, 2016 at 3:21 PM, M.H. Lian <minghuan.l...@nxp.com> wrote:
> Hi Bin,
>
> Thanks for your suggestion.
> Please see my comments inline.
>
> Thanks,
> Minghuan
>
>> -----Original Message-----
>> From: Bin Meng [mailto:bmeng...@gmail.com]
>> Sent: Monday, October 10, 2016 7:49 PM
>> To: M.H. Lian <minghuan.l...@nxp.com>; Simon Glass <s...@chromium.org>
>> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Mingkai Hu
>> <mingkai...@nxp.com>; Leo Li <leoyang...@nxp.com>
>> Subject: Re: [U-Boot] [PATCH 8/9] pci: layerscape: rewrite pci driver based 
>> on
>> DM
>>
>> Hi Minghuan,
>>
>> On Mon, Oct 10, 2016 at 4:47 PM, Minghuan Lian <minghuan.l...@nxp.com>
>> wrote:
>> > There are more than five kinds of Layerscape SoCs. unfortunately, PCIe
>> > controller of each SoC is a little bit different. In order to avoid
>> > too many macro definitions, the patch re-implement PCIe driver based
>> > on DM. PCIe dts node is to describe the difference.
>> >
>> > Signed-off-by: Minghuan Lian <minghuan.l...@nxp.com>
>> > ---
>> >  .../include/asm/arch-fsl-layerscape/immap_lsch3.h  |   8 -
>> >  drivers/pci/Kconfig                                |   8 +
>> >  drivers/pci/pcie_layerscape.c                      | 958 
>> > +++++++++++----------
>> >  include/configs/ls1012a_common.h                   |  12 +
>> >  include/configs/ls1012aqds.h                       |  24 -
>> >  include/configs/ls1012ardb.h                       |  24 -
>> >  include/configs/ls1021aqds.h                       |  18 +-
>> >  include/configs/ls1021atwr.h                       |  18 +-
>> >  include/configs/ls1043a_common.h                   |  23 +-
>> >  include/configs/ls2080a_common.h                   |  27 +-
>> >  include/configs/ls2080aqds.h                       |   8 -
>> >  include/configs/ls2080ardb.h                       |   8 -
>>
>> These header file changes should not be put in the same commit of the
>> layerscape PCIe driver conversion. They should be in a separate commit. So
>> you are likely to have 3 commits: firstly add DM codes with #ifdef
>> CONFIG_DM_PCI #endif in the layerscape PCIe driver, without breaking the
>> existing board support. 2nd commit to update the boards configuration files
>> (defconfig and the header), and 3rd commit to remove the #ifdef
>> CONFIG_DM_PCI #endif, only leaving the DM version codes.
>
> [Minghuan Lian] Your suggestion is excellent. I will change the patch.
> For  the header and defconfig files, do I need to separate them to several 
> patches for different SoC?
> I mean a patch is for ls1012, a patch is for ls1043 ...

It depends on how you organize your patch series. We should make every
commit bisectable, eg: the commit itself does not break build or any
functionality. If all SoC header files need to change all together, it
should be in one patch. Otherwise, you can put them into separate
patch.

Regards,
Bin
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to