On Tue, Oct 11, 2016 at 12:39:05PM -0500, Nishanth Menon wrote:

> Current logic for query of revision, board_name, config returns
> NULL. Users of these functions do a direct strncmp to compare.
> Unfortunately, as per conventions require two valid strings to compare
> against and the current implementation causes a crash when compared
> with NULL.
> We'd still like to maintain the simplistic usage of these APIs instead
> of redundant if (string) res=strncmp(fn(),"cmp",n); flowing all over
> the place.
> Hence, since the version, name and config is already pre-initialized
> with empty string, just dont check for invalid header in the first
> place and return the empty string to the caller.
> Reported-by: Brad Griffis <bgrif...@ti.com>
> Signed-off-by: Nishanth Menon <n...@ti.com>

Reviewed-by: Tom Rini <tr...@konsulko.com>


Attachment: signature.asc
Description: Digital signature

U-Boot mailing list

Reply via email to