On Fri, Oct 14, 2016 at 4:28 PM, Paul Kocialkowski <cont...@paulk.fr> wrote:
> Le jeudi 13 octobre 2016 à 13:47 +0300, Nicolae Rosia a écrit :
>> From: Nicolae Rosia <nicolae.ro...@gmail.com>
>> Commit a85362fb3e1fc7833723accddbbae431091d06b8 refactored the code
>> but the register read ended up in the wrong if branch.
>> Currently, the else branch checks a variable which is always 0.
> Good catch! Sorry for including that regression in the first place, I should
> have checked the patch more thoroughly.
No worries!

> See comment below.
> The indentation before &value is inconsistent with what is done in the rest of
> the file. I think you should either just move the line as it was or only use 
> one
> extra tab indent for the new line. Since this file breaks the 80 chars limit 
> in
> a few places, I would tend to prefer the former.
checkpatch.pl was complaining, that's why I formatted it.
@Tom Rini, can you apply it either way?

Best regards,
U-Boot mailing list

Reply via email to