Hi York, Thanks for reviewing! Please see inline.
> -----Original Message----- > From: york sun > Sent: Thursday, October 27, 2016 1:19 AM > To: [email protected]; [email protected] > Cc: S.H. Xie <[email protected]> > Subject: Re: [PATCH 2/2] armv8: ls1046aqds: add lpuart support > > On 09/26/2016 11:36 PM, [email protected] wrote: > > From: Shaohui Xie <[email protected]> > > > > LPUART0 is used by default, and it's using platform clock, if a > > different clock is preferred, user can define CONFIG_LPUART_CLK. > > Shaohui, > > You may have to choose another name for macro CONFIG_LPUART_CLK. We need > to avoid using CONFIG_*. If this clock is fixed on the board, you can use > SYS_FSL_* > name space. [S.H] I can drop the CONFIG_LPUART_CLK, it's not used on the QDS, I was thinking about to help user if their board uses different clock for LPUART and they don't want add code to calculate the frequency, they can just use a define. > > You can keep using CONFIG_LPUART for now, but eventually we will convert it to > Kconfig option. [S.H] OK. Thanks. Shaohui _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
