On Fri, Nov 11, 2016 at 11:20:47AM -0500, Tom Rini wrote: > On Tue, Nov 08, 2016 at 05:21:14PM +0100, Maxime Ripard wrote: > > > This program generates raw SPL images that can be flashed on the NAND with > > the ECC and randomizer properly set up. > > > > Signed-off-by: Maxime Ripard <maxime.rip...@free-electrons.com> > [snip] > > +++ b/tools/sunxi-spl-image-builder.c > > @@ -0,0 +1,1113 @@ > > +/* > > + * Generic binary BCH encoding/decoding library > > OK, but this is also lib/bch.c and re-using lib/ code for tools is a > normal best practice. I'd suggest re-factoring this code in sunxi-tools > sot that it too borrows lib/bch.c from the kernel (and can re-sync > bugfixes if needed). Thanks!
I finally figured that out. It turns out that the driver was doing a modulo by 0. I guess gcc's and our libgcc don't have the same behaviour in this case, but in U-boot's case, the function was simply returning (which is kind of odd). I'll send a fix for the driver. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
