On Mon, Nov 14, 2016 at 03:21:41PM +0100, Hans de Goede wrote: > Hi, > > On 14-11-16 15:12, Maxime Ripard wrote: > > On Mon, Nov 14, 2016 at 12:18:06PM +0100, Hans de Goede wrote: > > > > #ifdef CONFIG_SPL_SPI_SUNXI > > > > @@ -143,7 +157,14 @@ > > > > #define CONFIG_GENERIC_MMC > > > > #define CONFIG_MMC_SUNXI > > > > #define CONFIG_MMC_SUNXI_SLOT 0 > > > > -#define CONFIG_ENV_IS_IN_MMC > > > > +#endif > > > > + > > > > +#if defined(CONFIG_ENV_IS_IN_NAND) > > > > +#define CONFIG_ENV_OFFSET 0xc00000 > > > > +#define CONFIG_ENV_SIZE 0x400000 > > > > +#elif defined(CONFIG_ENV_IS_IN_MMC) > > > > +#define CONFIG_ENV_OFFSET (544 << 10) /* (8 + 24 > > > > + 512) KiB */ > > > > +#define CONFIG_ENV_SIZE (128 << 10) /* > > > > 128 KiB */ > > > > #define CONFIG_SYS_MMC_ENV_DEV 0 /* first detected MMC > > > > controller */ > > > > #endif > > > > Oh, and this part is broken. It relies on the fact that all board > > define ENV_IS_IN_MMC (which they should), while obviously they > > don't. I'm not exactly sure about what the proper fix would be. > > Yes, this has been a known problem for a while, but never > became an issue due to lack of NAND support. > > My preferred way for dealing with this be would for the > environment code in u-boot allowing to build in multiple > back-ends and use spl_boot_device() which then would need > to loose its spl prefix. For the CHIP devices I'm sure > you can come up with a simpler fix since those don't > have an sdcard-slot. But for other boards this will be > necessary as we really don't want to have separate > nand and mmc u-boot.bin files.
Ack, thanks. > Anyways this is something for whomever will take over as sunxi > custodian from me. Maybe someone from free-electrons can co-maintain > with Jagan ? Yes, that would make a lot of sense. I'll discuss this internally, and do the interim while we come up with someone. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot