Hi Oliver, On 8 November 2016 at 08:54, Olliver Schinagl <oli...@schinagl.nl> wrote: > Add the read_rom_hwaddr net_op hook so that it can be called from boards > to read the mac from a ROM chip. > > Signed-off-by: Olliver Schinagl <oli...@schinagl.nl> > --- > drivers/net/designware.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/net/designware.c b/drivers/net/designware.c > index 9e6d726..aa87f30 100644 > --- a/drivers/net/designware.c > +++ b/drivers/net/designware.c > @@ -230,6 +230,23 @@ static int _dw_write_hwaddr(struct dw_eth_dev *priv, u8 > *mac_id) > return 0; > } > > +__weak int dw_board_read_rom_hwaddr(unsigned char *enetaddr) > +{ > + return -ENOSYS; > +}
Instead of a weak function I think this should use driver model, with a driver supplied by the board to read this value. It should be possible to supply the 'hardware-address reading' device to any Ethernet driver, not just dwmmc. > + > +static int designware_eth_read_rom_hwaddr(struct udevice *dev) > +{ > + int retval; > + struct eth_pdata *pdata = dev_get_platdata(dev); > + > + retval = dw_board_read_rom_hwaddr(pdata->enetaddr); > + if (retval == -ENOSYS) > + return 0; > + > + return retval; > +} > + > static void dw_adjust_link(struct eth_mac_regs *mac_p, > struct phy_device *phydev) > { > @@ -685,6 +702,7 @@ static const struct eth_ops designware_eth_ops = { > .free_pkt = designware_eth_free_pkt, > .stop = designware_eth_stop, > .write_hwaddr = designware_eth_write_hwaddr, > + .read_rom_hwaddr = designware_eth_read_rom_hwaddr, > }; > > static int designware_eth_ofdata_to_platdata(struct udevice *dev) > -- > 2.10.2 > Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot