Hi, On 22 November 2016 at 03:49, Yehuda Yitschak <yehu...@marvell.com> wrote: > Hi Simon > >> -----Original Message----- >> From: s...@google.com [mailto:s...@google.com] On Behalf Of Simon Glass >> Sent: Friday, November 11, 2016 18:17 >> To: Yehuda Yitschak >> Cc: Bin Meng; Heiko Schocher; Przemyslaw Marczak; Stefan Roese; Stephen >> Warren; U-Boot Mailing List >> Subject: Re: [PATCH v2 1/1] cmd: pci: add option to parse and display BAR >> information >> >> Hi, >> >> On 6 November 2016 at 07:31, <yehu...@marvell.com> wrote: >> > From: Yehuda Yitschak <yehu...@marvell.com> >> > >> > Currently the PCI command only allows to see the BAR register values >> > but not the size and actual base address. >> > This little extension parses the BAR registers and displays the base, >> > size and type of each BAR. >> > >> > Signed-off-by: Yehuda Yitschak <yehu...@marvell.com> >> > --- >> > cmd/pci.c | 95 >> > >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> +++++ >> > 1 file changed, 95 insertions(+) >> >> Reviewed-by: Simon Glass <s...@chromium.org> [...]
>> >> > + bar_id, base, size, is_64 ? 64 : 32, >> > + is_io ? "I/O" : "MEM", >> > + prefetchable ? "Prefetchable" : ""); >> >> Check with sandbox, this gives a warning: >> >> cmd/pci.c: In function ‘pci_bar_show’: >> cmd/pci.c:175:11: warning: format ‘%llx’ expects argument of type ‘long long >> unsigned int’, but argument 3 has type ‘u64’ [-Wformat=] >> prefetchable ? "Prefetchable" : ""); >> ^ > > Strange, I can't see that. > What compiler are you using when you get the warning ? > I am using gcc-4.8 for armv8, maybe that's why I don't see the warnings > I might come down to the built-in definition of __UINT64_TYPE__ which the > sandbox arch uses This is sandbox, perhaps this: gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04.3) [...] Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot