Hi Mugunthan, On 17 November 2016 at 02:08, Mugunthan V N <[email protected]> wrote: > Add a TI MUSB peripheral driver with driver model support and the > driver will be bound by the MUSB wrapper driver based on the > dr_mode device tree entry. > > Signed-off-by: Mugunthan V N <[email protected]> > Reviewed-by: Simon Glass <[email protected]> > --- > drivers/usb/musb-new/musb_uboot.c | 2 + > drivers/usb/musb-new/ti-musb.c | 109 > ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 111 insertions(+) > > diff --git a/drivers/usb/musb-new/musb_uboot.c > b/drivers/usb/musb-new/musb_uboot.c > index ea71f75947..46e3faeeaa 100644 > --- a/drivers/usb/musb-new/musb_uboot.c > +++ b/drivers/usb/musb-new/musb_uboot.c > @@ -373,6 +373,7 @@ struct dm_usb_ops musb_usb_ops = { > #endif /* CONFIG_DM_USB */ > #endif /* CONFIG_USB_MUSB_HOST */ > > +#ifndef CONFIG_DM_USB > #ifdef CONFIG_USB_MUSB_GADGET > static struct musb *gadget; > > @@ -453,3 +454,4 @@ int musb_register(struct musb_hdrc_platform_data *plat, > void *bdata, > > return 0; > } > +#endif /* CONFIG_DM_USB */ > diff --git a/drivers/usb/musb-new/ti-musb.c b/drivers/usb/musb-new/ti-musb.c > index 1c15aa2a42..b8abc1dc58 100644 > --- a/drivers/usb/musb-new/ti-musb.c > +++ b/drivers/usb/musb-new/ti-musb.c > @@ -14,6 +14,7 @@ > #include <dm/device-internal.h> > #include <dm/lists.h> > > +#include <watchdog.h> > #include <asm/io.h> > #include <asm/omap_musb.h> > #include "musb_uboot.h" > @@ -142,6 +143,106 @@ static int ti_musb_ofdata_to_platdata(struct udevice > *dev) > return 0; > } > > +static struct musb *gadget;
Can you please drop this static struct? We should not use this sort of thing with driver model. Let me know if you want ideas on how. Regards, Simon _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
